[MIRROR] Remove 2 instances of duplicate argument names #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove 2 instances of duplicate argument names (#81757) ## About The Pull Request I fixed 2 instances of procs having multiple arguments with the same name. BYOND does not error on these, instead ignoring all but the last. It's best to remove these for clarity. ## Why It's Good For The Game N/A --------- Co-authored-by: san7890 <[email protected]> * Remove 2 instances of duplicate argument names --------- Co-authored-by: wixoa <[email protected]> Co-authored-by: san7890 <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Fixes runtime in z level update (#82898) ## About The Pull Request re-adds the check that they are actually being moved to a new z level in the update z level proc so it doesn't check null z level for cliented mobs and ai controllers. ## Why It's Good For The Game Saw this runtime on moth.fans and thought i should fix it. ## Changelog Nothing player-facing. * Fixes runtime in z level update --------- Co-authored-by: John Willard <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Fixes runtime in z level update (#82898) ## About The Pull Request re-adds the check that they are actually being moved to a new z level in the update z level proc so it doesn't check null z level for cliented mobs and ai controllers. ## Why It's Good For The Game Saw this runtime on moth.fans and thought i should fix it. ## Changelog Nothing player-facing. * Fixes runtime in z level update --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1229
Original PR: tgstation/tgstation#81757
About The Pull Request
I fixed 2 instances of procs having multiple arguments with the same name. BYOND does not error on these, instead ignoring all but the last. It's best to remove these for clarity.
Why It's Good For The Game
N/A